Repository navigation
module: await the cycle roots capability promise, if needed - #66810
Open
avivkeller wants to merge 2 commits into
Open
avivkeller wants to merge 2 commits into
avivkeller wants to merge 2 commits into
Conversation
Signed-off-by: avivkeller <me@aviv.sh>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66810 +/- ##
==========================================
+ Coverage 90.50% 90.53% +0.02%
==========================================
Files 797 800 +3
Lines 277785 280493 +2708
Branches 53365 54143 +778
==========================================
+ Hits 251418 253945 +2527
+ Misses 16753 16666 -87
- Partials 9614 9882 +268
🚀 New features to boost your workflow:
|
GeoffreyBooth
approved these changes
Oct 18, 2026
joyeecheung
approved these changes
Oct 21, 2026
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66806 by waiting for a module, if
status === kEvaluated && this.module.hasAsyncGraphresolves totrue.